Allow metadata.name or metadata.generateName in GetValidatedMetadata()

[anthonyserious]

Modify GetValidatedMetadata to pass when at least one of metadata.name and metadata.generateName is defined. #641

[k8s-ci-robot]

@anthonyserious: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: anthonyserious / name: Anthony Schneider (379ace2, 8165fda, 74bb78d)

[k8s-ci-robot]

Welcome @anthonyserious!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @anthonyserious. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anthonyserious
Once this PR has been reviewed and has the lgtm label, please assign phanimarupaka for approval by writing /assign @phanimarupaka in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• kyaml/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sharkymcdongles]

@anthonyserious can you join a CLA so we can get this merged? :D

[anthonyserious]

@anthonyserious can you join a CLA so we can get this merged? :D

Working on it, sorry!

[anthonyserious]

CLA approved. 👍

[anthonyserious]

Hi @mengqiy and @phanimarupaka - would it be possible to approve this for running workflows? Sorry it took so long to get my CLA set up.

[KnVerey]

We would love to support generateName, but I think the solution is more complicated than the current state of this PR. The underlying reason is that a lot of Kustomize's functionality depends on object identity, and the metadata.name is a key piece of that (and so metadata.generateName would be as well). It's possible most of our transformers should effectively ignore resources that use this field, but I think each deserves careful consideration and will need a test demonstrating that its behaviour is as intended with these resources. Please have a look at this earlier attempt at a solution, and Natasha's comment in particular: #4838 (comment).

[anthonyserious]

Thanks, @KnVerey, I suspected this would be the case. I'll close this and hopefully the PR you mentioned moves forward. 👍