define methods, types, and unit tests for transformer annotations #4357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining some types and methods that will be necessary for the implementation of the transformer annotation proposal.
Added unit tests for new methods as well as for methods defined in #4341.
As described in #4267 (comment), in order to account for the case where there is a generator in the transformers field, we will add an origin annotation when there is none - i.e. assume that the transformer generated the resource; otherwise we will add a transformer annotation. In order for this to work, we will have to keep track of both the origin and the transformer data when either option is set. At the end of
kustomize build
, if only one of the origin or transformer options is set, we need to discard the other annotation. This will be taken care of by a future PR, but this context is needed to understand the implementation ofresWrangler.AddTransformerAnnotation
and is the reason for introducingResMap.RemoveOriginAnnotations()
andResMap.RemoveTransformerAnnotations()
.A followup PR will use these new types and methods to track and annotate each resource with transformer data.
/cc @KnVerey
/cc @yuwenma