Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json-patch upgrade to v4.11.0 #3966

Merged
merged 1 commit into from
Jun 15, 2021
Merged

json-patch upgrade to v4.11.0 #3966

merged 1 commit into from
Jun 15, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jun 7, 2021 •
edited by monopole
Loading

refer to kubernetes/kubernetes#102467

k/k has upgraded it to v4.11.0.

kyaml/kio/byteio_writer.go change is after I run hack/kyaml-pre-commit.sh. I think it is valid.

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from droot and KnVerey June 7, 2021 01:54
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @pacoxu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2021
@KnVerey
Copy link
Contributor

KnVerey commented Jun 7, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2021
@natasha41575
Copy link
Contributor

@pacoxu you can run make prow-presubmit-check locally to run the test here, looks like something is missing a go.sum entry

@pacoxu pacoxu force-pushed the json-patch-v4.11.0 branch from 7e23e4c to 5844c6e Compare June 8, 2021 04:03
@pacoxu
Copy link
Member Author

pacoxu commented Jun 8, 2021

@natasha41575 Updated,

Thanks./

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 8, 2021
@pacoxu pacoxu force-pushed the json-patch-v4.11.0 branch from 5844c6e to 4fe6e8c Compare June 8, 2021 04:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2021
@pacoxu pacoxu force-pushed the json-patch-v4.11.0 branch from 4fe6e8c to 21dae54 Compare June 8, 2021 05:05
@monopole
Copy link
Contributor

monopole commented Jun 8, 2021

Please squash the commits.

@monopole
Copy link
Contributor

monopole commented Jun 8, 2021

/test
kustomize-presubmit-master

@k8s-ci-robot
Copy link
Contributor

@monopole: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test kustomize-presubmit-master

Use /test all to run all jobs.

In response to this:

/test
kustomize-presubmit-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@monopole
Copy link
Contributor

monopole commented Jun 8, 2021

/test kustomize-presubmit-master

@pacoxu pacoxu force-pushed the json-patch-v4.11.0 branch 6 times, most recently from 1ba3a6f to ab22b53 Compare June 9, 2021 04:02
@pacoxu pacoxu force-pushed the json-patch-v4.11.0 branch from ab22b53 to 24294d3 Compare June 9, 2021 04:34
@pacoxu
Copy link
Member Author

pacoxu commented Jun 9, 2021

Please the commits.

squashed @monopole

pacoxu
pacoxu commented Jun 9, 2021
View reviewed changes
functions/examples/application-cr/image/go.mod
@@ -3,6 +3,7 @@ module sigs.k8s.io/kustomize/functions/examples/application-cr
go 1.16

require (
github.com/evanphx/json-patch v4.11.0+incompatible
k8s.io/apimachinery v0.18.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/go.mod#L10

apimachinery currently requires json-patch v4.11.0.

github.com/evanphx/json-patch v4.2.0+incompatible/go.mod h1:50XU6AFN0ol/bzJsmQLiYLvXMP4fmwYFNcr97nuDLSk=

should be removed once k8s.io/apimachinery upgrade to k/k master version.

@pacoxu pacoxu mentioned this pull request Jun 9, 2021
Closed
6 tasks
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jun 15, 2021

/assign @monopole

@natasha41575
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit d39d7db into kubernetes-sigs:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@monopole monopole

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @k8s-ci-robot @KnVerey @natasha41575 @monopole