Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remove resource subcommand #1057

Merged
merged 2 commits into from
May 13, 2019

Conversation

narg95
Copy link
Contributor

@narg95 narg95 commented May 8, 2019

What it does

It adds kustomize edit remove resource command.

Usage:
  kustomize edit remove resource [flags]

Examples:

		remove resource my-resource.yml
		remove resource resource1.yml resource2.yml resource3.yml
		remove resource resources/*.yml

It closes issue #873

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from droot and monopole May 8, 2019 14:08
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2019
@narg95
Copy link
Contributor Author

narg95 commented May 8, 2019

/assign @monopole
/assign @Liujingfang1

@monopole
Copy link
Contributor

nice job on the tests.
nice job allowing room for more remove subcommands
thanks!

Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2019
c := &cobra.Command{
Use: "remove",
Short: "Removes items to the kustomization file.",
Long: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. After a quick read of the tests, is remove, removing items from the kustomization file?
See lines 28 and 38.

@narg95
Copy link
Contributor Author

narg95 commented May 11, 2019

@monopole you are welcome!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: narg95
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: liujingfang1

If they are not already assigned, you can assign the PR to them by writing /assign @liujingfang1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@monopole
Copy link
Contributor

/lgtm (fixed the to/from issue mentioned by @kbhawkey )

@monopole monopole merged commit 95e4cc1 into kubernetes-sigs:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants