-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add remove resource subcommand #1057
add remove resource subcommand #1057
Conversation
/assign @monopole |
nice job on the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
c := &cobra.Command{ | ||
Use: "remove", | ||
Short: "Removes items to the kustomization file.", | ||
Long: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. After a quick read of the tests, is remove
, removing items from
the kustomization file?
See lines 28 and 38.
@monopole you are welcome! |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: narg95 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm (fixed the to/from issue mentioned by @kbhawkey ) |
What it does
It adds
kustomize edit remove resource
command.It closes issue #873