Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: put path/type in json patch rather than in kustomization.yaml #824

Closed
donbowman opened this issue Feb 26, 2019 · 5 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@donbowman
Copy link
Contributor

Currently we have json patches split into two spots (kustomization.yaml and the patch itself):

patchesJson6902:
  - target:
      version: v1
      kind: Service
      name: nginx-ingress-controller
    path: controller-service.yaml

  - target:
      group: extensions
      version: v1beta1
      kind: Deployment
      name: nginx-ingress-controller
    path: controller-deployment.yaml

...
---
- op: add
  path: /spec/ports/-
  value: {"name": "24224-tcp", "port": 24224, "protocol": "TCP", "targetPort": "24224-tcp"}
- op: replace
  path: /spec/loadBalancerIP
  value: "52.167.3.63"

This makes it hard to manage (since i'm often making a similar patch to 2 or more base files). It would be simpler if the type/path was in the patch, like below.

E.g. when changing a containerPort across the deployment + service + ingress, its easier to manage a single file called 'change the port' than 3 files + the config in the kustomization.yaml.

---

 kind: Service
 name: foo
 patch:
   - op: add
     path: /spec/ports/-
     value: {"name": "24224-tcp", "port": 24224, "protocol": "TCP", "targetPort": "24224-tcp"}
   - op: replace
     path: /spec/loadBalancerIP
     value: "52.167.3.63"

---
 kind: extensions/v1beta1
 name: foo
 patch:
   - op: replace
     ...
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marshallford
Copy link

Is there an example of how to move the target data into the patch file now that #1355 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants