Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard history navigation does not work in Popup clients #6263

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Nov 26, 2020

Fixes #6262

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #6263 (296f4e1) into master (c74e787) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6263   +/-   ##
=======================================
  Coverage   61.94%   61.94%           
=======================================
  Files          85       85           
  Lines        2670     2670           
  Branches      660      660           
=======================================
  Hits         1654     1654           
  Misses        771      771           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74e787...939d819. Read the comment docs.

@starpit starpit merged commit 89197ba into kubernetes-sigs:master Nov 26, 2020
@starpit starpit deleted the fix-6262 branch November 26, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyboard history navigation does not work in Popup clients
1 participant