Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable splits for popup mode? #7542

Closed
starpit opened this issue Jun 6, 2021 · 0 comments · Fixed by #7543
Closed

enable splits for popup mode? #7542

starpit opened this issue Jun 6, 2021 · 0 comments · Fixed by #7543

Comments

@starpit
Copy link
Contributor

starpit commented Jun 6, 2021

Now that we have a way to close splits via the UI, we may consider enabling splitTerminals for "popup" mode. In Popup mode, we use a bottom input; without a clicky/visual way to close splits, popup modes and splits are incompatible.
starpit added a commit to starpit/kui that referenced this issue Jun 6, 2021
@starpit
feat: enable splits for popup mode
aae21fc 
part of kubernetes-sigs#7542
starpit added a commit to starpit/kui that referenced this issue Jun 6, 2021
@starpit
feat: enable splits for popup mode
4a34f4f 
part of kubernetes-sigs#7542
@starpit starpit mentioned this issue Jun 6, 2021
Merged
7 tasks
k8s-ci-robot pushed a commit that referenced this issue Jun 7, 2021
@starpit @k8s-ci-robot
feat: enable splits for popup mode
0b95d9c 
part of #7542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable splits for popup mode starpit/kui
1 participant
@starpit