Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: when rerunning blocks, output always scrolls to bottom #7527

Closed
starpit opened this issue Jun 4, 2021 · 1 comment · Fixed by #7528 or #7531
Closed

regression: when rerunning blocks, output always scrolls to bottom #7527

starpit opened this issue Jun 4, 2021 · 1 comment · Fixed by #7528 or #7531
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release.

Comments

@starpit
Copy link
Contributor

starpit commented Jun 4, 2021

Small regression from #7525
@starpit starpit added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jun 4, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2021
@starpit
fix(plugins/plugin-client-common): when rerunning blocks, output alwa…
a5e4149 
…ys scrolls to bottom

part of kubernetes-sigs#7527
@starpit starpit mentioned this issue Jun 4, 2021
Merged
7 tasks
k8s-ci-robot pushed a commit that referenced this issue Jun 4, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-client-common): when rerunning blocks, output alwa…
4e360a9 
…ys scrolls to bottom

part of #7527
@starpit
Copy link
Contributor Author

starpit commented Jun 4, 2021

the fix wasn't quite right. the implement of BlockModel.hasBeenRerun wasn't quite right.

@starpit starpit reopened this Jun 4, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2021
@starpit
regression: when rerunning blocks, output always scrolls to bottom (p…
e082f78 
…art b)

part of kubernetes-sigs#7527
@starpit starpit mentioned this issue Jun 4, 2021
Merged
7 tasks
k8s-ci-robot pushed a commit that referenced this issue Jun 4, 2021
@starpit @k8s-ci-robot
regression: when rerunning blocks, output always scrolls to bottom (p…
4441ecd 
…art b)

part of #7527
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2021
@starpit
fix(plugins/plugin-client-common): when rerunning blocks, output alwa…
6c70296 
…ys scrolls to bottom

part of kubernetes-sigs#7527
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2021
@starpit
regression: when rerunning blocks, output always scrolls to bottom (p…
50392f4 
…art b)

part of kubernetes-sigs#7527
k8s-ci-robot pushed a commit that referenced this issue Jun 4, 2021
@starpit @k8s-ci-robot
fix(plugins/plugin-client-common): when rerunning blocks, output alwa…
23e6728 
…ys scrolls to bottom

part of #7527
k8s-ci-robot pushed a commit that referenced this issue Jun 4, 2021
@starpit @k8s-ci-robot
regression: when rerunning blocks, output always scrolls to bottom (p…
34418c5 
…art b)

part of #7527
@starpit starpit closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release.
Projects
None yet
Milestone
No milestone
1 participant
@starpit