Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to close the output window #7060

Closed
RealHarshThakur opened this issue Feb 22, 2021 · 7 comments
Closed

Option to close the output window #7060

RealHarshThakur opened this issue Feb 22, 2021 · 7 comments
Labels
design 🎨 lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@RealHarshThakur
Copy link

When I run a command to view a resource, I would like to close the output window on the right hand side as it takes a lot of space. I think this was possible in previous versions.

@starpit
Copy link
Contributor

starpit commented Feb 22, 2021

Hello, and thanks for the feedback!

The split to the side is now a normal terminal split. You may close it as you would any terminal, e.g. via ctrl+d or by typing "exit".

We have been brainstorming on a way to make this kind of "one-off drilldown" more convenient. Perhaps having a close button somewhere in each split? Or should Escape close the currently-focused split? Thoughts?

@RealHarshThakur
Copy link
Author

@starpit Yes, that would be nice. I really like the current setup as it has screenshot functionality and scrolling to previous outputs. Although It would be nice to have the maximize and close button like the older version does .
image

@starpit
Copy link
Contributor

starpit commented Feb 22, 2021

Great idea! We'll try to cook something up.

@starpit
Copy link
Contributor

starpit commented Feb 25, 2021

To start with, we have added some lightweight placeholder text to instruct users that ctrl+d will close the split (ctrl+d was already supported, but now Kui advertises this a bit more). #7068

The keyboard strategy for this is:

  1. k get pods (e.g.)
  2. click on myPod
  3. ...inspect the pod...
  4. ctrl+d to close; as long as you have not otherwise clicked around, the prompt in the new split will have focus, and so ctrl+d without any mouse motion will immediately close that new split

This isn't a 100% solution, but hopefully it goes some way towards addressing this UX issue. Clearly the entire issue remains unresolved, so this issue will remain open.

The ctrl+d placeholder text enhancement was released in 10.2.0.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2021
@starpit
Copy link
Contributor

starpit commented Jun 8, 2021

We have merged in some UI enhancements that will be released soon, with 10.4.0. Each split pane will now have its own close button.

Screen Shot 2021-06-08 at 12 55 34 PM

@RealHarshThakur
Copy link
Author

Awesome @starpit ! Thanks, really appreciate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design 🎨 lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants