Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on linux, cat bigfile.json ends prematurely #1765

Closed
starpit opened this issue Jun 18, 2019 · 5 comments
Closed

on linux, cat bigfile.json ends prematurely #1765

starpit opened this issue Jun 18, 2019 · 5 comments
Labels
backlog kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. platform/linux plugin/bash-like

Comments

@starpit
Copy link
Contributor

starpit commented Jun 18, 2019

i'm not completely sure where the bug is yet, but signs point to a bug in node-pty:

microsoft/node-pty#85

test case:

cat plugins/plugin-bash-like/tests/data/big.json

on mac, you will see the full JSON rendered in the sidecar; on mac, you will see a truncated JSON string appear in the REPL. this is because the underlying node-pty (to the best of my current understanding) emits an 'exit' event prior to all of the data being sent on 'data' events. i have inserted printfs down to the level of node-pty/lib/unixTerminal.js, and i see 'exit' and socket 'close' events being sent, and even with a long setTimeout... i do not see the trailing JSON appear, ever.

@starpit starpit added kind/bug Categorizes issue or PR as related to a bug. plugin/bash-like platform/linux backlog labels Jun 18, 2019
@starpit
Copy link
Contributor Author

starpit commented Jun 19, 2019

marking as backlog, as this is blocked by an underlying issue in node-pty

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 23, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. platform/linux plugin/bash-like
Projects
None yet
Development

No branches or pull requests

3 participants