Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3152: [batch/job] Allow unsuspending a job with a parallelism equal or less then minimum. #3207

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Oct 9, 2024

Cherry pick of #3152 on release-0.8.

#3152: [batch/job] Allow unsuspending a job with a parallelism equal or less then minimum.

For details on the cherry pick process, see the cherry pick requests page.

Fix webook validation for batch/Job to allow partial admission of a Job to use all available resources.
It also fixes a scenario of partial re-admission when some of the Pods are already reclaimed.

The minimum can be reached in the usual partial admission operation.
Values less then minimum can be reached in case of readmitting jobs
which have marked a good part of their pods as reclaimable.
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 27a938a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6706901b3c30a30008ffa644
😎 Deploy Preview https://deploy-preview-3207--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trasc trasc mentioned this pull request Oct 9, 2024
4 tasks
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

@trasc Could you post the place where we faced conflicting?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f14b1f077f3b872a79602685e20ed78ec3324c73

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@trasc
Copy link
Contributor Author

trasc commented Oct 9, 2024

The conflict was triggered by the movement of job webhook integration tests. (mot relevant to the PR)

@tenzen-y
Copy link
Member

tenzen-y commented Oct 9, 2024

The conflict was triggered by the movement of job webhook integration tests. (mot relevant to the PR)

Thanks.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5e43337 into kubernetes-sigs:release-0.8 Oct 9, 2024
16 checks passed
@trasc trasc deleted the automated-cherry-pick-of-#3152-upstream-release-0.8 branch October 24, 2024 14:58
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants