-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workload] Add maximum execution time. #3184
[workload] Add maximum execution time. #3184
Conversation
Skipping CI for Draft Pull Request. |
/test all |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
c3b99a3
to
aee16f2
Compare
/test all |
1 similar comment
/test all |
f60d1cc
to
ab6e7ee
Compare
/test all |
/cc @tenzen-y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: c59fa3127a27f351d4a8c55cfd4449561b927f35
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All /release-note-edit
|
/release-note-none |
* [api][workload] Add `MaximumExecutionTime` * [api][workload] Add `MaximumExecutionTime` - generate * [controller][workload] Enforce `MaximumExecutionTime` * [webhook][workload] Validate `MaximumExecutionTime` * [workload] Don't deactivate twice * Realign with KEP * Review Remarks * Review remarks
* [api][workload] Add `MaximumExecutionTime` * [api][workload] Add `MaximumExecutionTime` - generate * [controller][workload] Enforce `MaximumExecutionTime` * [webhook][workload] Validate `MaximumExecutionTime` * [workload] Don't deactivate twice * Realign with KEP * Review Remarks * Review remarks
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add maximum execution time support for workloads.
A new optional field is added
spec.maximumExecutionTimeSeconds
which can specify the maximum time (in second) it is allowed to be admitted. Once this time is exceeded, the workload is automatically deactivated.Which issue(s) this PR fixes:
Related to #3125
Special notes for your reviewer:
This is part 1 out of 3 in the implementation of #3133, the jobs integration and admission time accumulation are implemented in the next two PRs.
Does this PR introduce a user-facing change?