[cache] Add more details in the clusterQueues inactive message. #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mimowo
reviewed
Sep 25, 2024
k8s-ci-robot
added
release-note-action-required
|
I don't understand the message myself for MultipleSingleInstanceControllerAdmissionChecks, as mentioned in: #3127 (comment). I hope we can revisit this after dropping the current mechanism per #3094, which is intrinsically confusing. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a064a970c3695395ec4eceef027303fd0410401c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
…rnetes-sigs#3127) * [cache] Add more details in the clusterQueues inactive message. * Review Remarks * Review Remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
[cache] Add more details in the clusterQueues inactive message.
Enhance the detail level in the ClusterQueues
status.conditions[Active].messageto possibly incorporate the Flavors and/or AdmissionChecks that are causing the inactive status.Which issue(s) this PR fixes:
Fixes #3099
Special notes for your reviewer:
Does this PR introduce a user-facing change?