-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a BaseWebhook that replaces all kubeflow webhooks #3102
Add a BaseWebhook that replaces all kubeflow webhooks #3102
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
b44c458
to
28d2e22
Compare
Change-Id: Ia6343aa06900654011dec92ff4136b8c2deeaf3f
28d2e22
to
8d04237
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
LGTM label has been added. Git tree hash: 313e1f5f3a611c46ce7521e4083f8aa89ee30b5c
|
/cherry-pick release-0.8 |
@mbobrovskyi: #3102 failed to apply on top of branch "release-0.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…s#3102) Change-Id: Ia6343aa06900654011dec92ff4136b8c2deeaf3f
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Introduce a BaseWebhook that can be used as-is for most job integrations. This removes a lot of repeated code for kubeflow.
Which issue(s) this PR fixes:
I did this in preparation for #2878
It can also justify the removal of integration tests for most kubeflow jobs #2993
Special notes for your reviewer:
Does this PR introduce a user-facing change?