Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include visibility-api.yaml as a part of main.yaml. #3084

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Include visibility-api.yaml as a part of main.yaml. #3084

merged 1 commit into from
Sep 19, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Sep 18, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Include visibility-api.yaml as a part of main.yaml.

Which issue(s) this PR fixes:

Part of #2973

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Included visibility-api.yaml as a part of main.yaml

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 67ba957
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66ebcdfe9a3c1f00087ccef5

@mbobrovskyi mbobrovskyi force-pushed the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch from 3f18d54 to 2cb12ae Compare September 18, 2024 10:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch from 2cb12ae to 7b38d1c Compare September 18, 2024 10:29
This was referenced Sep 18, 2024
Closed
Merged
@alculquicondor
Copy link
Contributor

/assign @mimowo

mimowo
mimowo reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @PBundyra

@mbobrovskyi mbobrovskyi force-pushed the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch from 7b38d1c to 78ae62b Compare September 18, 2024 16:22
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch from 78ae62b to 603f8a4 Compare September 19, 2024 06:54
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch from 603f8a4 to 67ba957 Compare September 19, 2024 07:08
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2024
@mbobrovskyi
Copy link
Contributor Author

@PBundyra @mimowo, would you like to add anything?

@mimowo
Copy link
Contributor

mimowo commented Sep 19, 2024 •
edited
Loading

@PBundyra @mimowo, would you like to add anything?

/lgtm
/approve

If @PBundyra has some comments we can address them in a follow up.
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d20094f8e3e1d37500c0d31b62bd479d242bd739

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit e971646 into kubernetes-sigs:main Sep 19, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 19, 2024
@mbobrovskyi mbobrovskyi deleted the feature/include-visibility-api-yaml-as-a-part-of-main-yaml branch September 19, 2024 12:20
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Include visibility-api.yaml as a part of main.yaml. (kubernetes-sigs#…
c0659f6 
…3084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@PBundyra PBundyra Awaiting requested review from PBundyra

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mbobrovskyi @alculquicondor @mimowo @k8s-ci-robot