Implement Cohort cycle detection in hierarchy.Manager #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @mimowo |
gabesaba
force-pushed
the
cycle_detection
branch
from
c4a1817
to
31762c2
Compare
mimowo
reviewed
Sep 13, 2024
| operations func(M) | ||
| wantCycles map[string]bool | ||
| }{ | ||
| "no cycles": { |
There was a problem hiding this comment.
Add a test case for a diamond structure.
root
/ \
left right
\ /
shared child
should be no cycles, but I would like to confirm there is no bug here.
There was a problem hiding this comment.
We can't represent this configuration, as a child can only have one parent
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 07c486b77916405ab499711c744034644ca3fbea
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Cycle checking logic in hierarchy.Manager. Will be used by both
queue.managerandcache.Cache. I'm pulling it out of #3006 to reduce diff. Part of #79Special notes for your reviewer:
Does this PR introduce a user-facing change?