-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate MultiplePreemptions to Beta #2864
Graduate MultiplePreemptions to Beta #2864
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, macsko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: af59462725131c035c2202d2b87926370f2a2257
|
Hi, I couldn't find any explicit mention of Based on its name, I thought that enabling it allows high-priority workloads to preempt multiple workloads (in other words, by default, workloads can only preempt at most 1 workload), but based on testing a toy example, it seems that high-priority workloads can already do this (even without the Test:
What I observed is that after step 2, both low-priority jobs were running. Upon submitting the high-priority job, both the low-priority jobs became pending and the high-priority job got admitted. |
Ah, I just realized this has already been merged. |
Yeah, that's true. After we release v0.9.0, this feature is enabled by default, and we can see the details in the website. |
We didn't document it because it was meant to become the default behavior and it might not be a very common scenario that users run into. But you can find more details in the original PR #2641 |
Just to confirm, this feature is also enabled by default if I'm using v0.8.1, right? Since this PR got merged prior to the 0.8.1 release. Hence why my simple test case allowed both low-prio workloads to get preempted (I'm using 0.8.1). |
The feature will only be enabled by default in v0.9. Your test case has always worked. This feature is about multiple preemptions from multiple ClusterQueues in a cohort. It always faster throughput of preemptions when pods take a long time to finish. |
Thanks for your clarification. The |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Graduate MultiplePreemptions feature to beta and enable it by default.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?