[Partial Admission] Check Mode before attempting Preemption #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bea9931376c9e0f949a05daff5a14ff01a159ab7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabesaba, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gabesaba
added a commit
to gabesaba/kueue
that referenced
this pull request
Aug 13, 2024
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Cleanup to use FlavorResourceQuantities.Add in cache (#2696) * fix: Refactor FitInCohort tests (#2655) * fix: Refactor FitInCohorot tests * fix: delete no-op function * fix: use new method to add usage * fix: to enforce resource group constraint for flavors and resources * fix: consolidated into a single resource group * fix: delete flavorNames * fix: adjusted test cases to align with existing expected conditions * fix: change FlavorResourceQuantitiesFlat value * Finish flattening of FlavorResourceQuantities (#2721) * Finish Flattenning FlavorResourceQuantities * Rename FlavorResourceQuantitiesFlat to FlavorResourceQuantities * Cleanup preemption.go (#2800) * [Partial Admission] Check Mode before attempting Preemption (#2809) * Prefer Reclamation to Priority Based Preemption (#2811) --------- Co-authored-by: s-shiraki <[email protected]>
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We don't check
RepresentativeModebefore attempting preemption in thePartial Admissionpath. This may result in a panic, if we enter the preemption path and find some targets.In the existing unit tests, we exit here, before encountering a panic here. See #2799 for more detail.
Which issue(s) this PR fixes:
Related to #2799. Leaving that issue open, as related tests need to be updated
Does this PR introduce a user-facing change?