Provide Kubeflow PaddleJob support for MultiKueue #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/ok-for-test |
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mszadkow
force-pushed
the
feature/support-kubeflow-paddle-in-mk
branch
from
eadfbb6
to
ed4df4d
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3d7b04659f647403edb47527c34abc201e90473f
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
tenzen-y
reviewed
Aug 1, 2024
pkg/controller/jobs/kubeflow/jobs/paddlejob/paddlejob_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
pkg/controller/jobs/kubeflow/jobs/paddlejob/paddlejob_multikueue_adapter.go
Outdated
Show resolved
Hide resolved
k8s-ci-robot
removed
the
lgtm
|
@tenzen-y updated ptal |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 77b2502ca586c4956d1f802b0fbaf1c9a237b081
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mszadkow, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
* Provide Kubeflow PaddleJob support for MultiKueue * update after code review * fix after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The PR introduces a new MultiKueue adapter to handle PaddleJob (Kubeflow).
We want to extend MultiKueue capabilities to satisfy the needs of early adopters.
Which issue(s) this PR fixes:
Relates #2552
Special notes for your reviewer:
Does this PR introduce a user-facing change?