Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for JobSet fix on suspend #2700

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add e2e test for JobSet fix on suspend #2700

merged 1 commit into from
Sep 16, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jul 25, 2024

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

WIP because for now this is just an e2e that documents the issue. We will be able to fix it once kubernetes-sigs/jobset#625 is fixed at the JobSet side, and is bumped in Kueue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 67c4ebe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66e7d1a45f24a50008ca3c29

@mimowo mimowo mentioned this pull request Jul 25, 2024
Closed
@mimowo mimowo force-pushed the kueue-jobset-test branch 2 times, most recently from c926347 to 7e68d56 Compare July 25, 2024 16:57
@kannon92
Copy link
Contributor

kannon92 commented Aug 20, 2024 •
edited
Loading

Testing #2865 with jobset update.

JobSet is going to need 0.30.4 so we may need to upgrade k8s in Kueue.

@kannon92 kannon92 mentioned this pull request Aug 26, 2024
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 2, 2024 •
edited
Loading

@mimowo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-27 7e68d56 link true /test pull-kueue-test-e2e-main-1-27

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kannon92
Copy link
Contributor

@mimowo when you get a chance do you want to rebase this?

@mimowo mimowo changed the title WIP: Add e2e test for JobSet fix on the suspend Add e2e test for JobSet fix on the suspend Sep 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Sep 16, 2024 •
edited
Loading

Rebased, example failure before the rebase:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/2700/pull-kueue-test-e2e-main-1-30/1830548852046827520 (e2e tests were failing consistently for all runs)

@mimowo mimowo changed the title Add e2e test for JobSet fix on the suspend Add e2e test for JobSet fix on suspend Sep 16, 2024
@kannon92
Copy link
Contributor

/lgtm

/assign @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47be11e7f82a2a225149cdce342bf973379c6c4b

@k8s-ci-robot k8s-ci-robot merged commit 9b53c41 into kubernetes-sigs:main Sep 16, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 16, 2024
@mimowo mimowo mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@kannon92 kannon92

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mimowo @k8s-ci-robot @kannon92 @tenzen-y