Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about the need to restart the kueue pod #2685

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jul 24, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

To avoid users confusion when the CRDs don't work.
This is needed until #2414 is fixed

Which issue(s) this PR fixes:

Related to #2414

Special notes for your reviewer:

We can remove the notes once the issue is fixed, if cherry-picked. If not cherry-picked, we can update the docs to say that this is needed prior to 0.9.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 6bed9d4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66a0c6575775060008630acd
😎 Deploy Preview https://deploy-preview-2685--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor Author

mimowo commented Jul 24, 2024

/assign @tenzen-y @ChristianZaccaria

@k8s-ci-robot
Copy link
Contributor

@mimowo: GitHub didn't allow me to assign the following users: ChristianZaccaria.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @tenzen-y @ChristianZaccaria

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor Author

mimowo commented Jul 24, 2024

cc @ChristianZaccaria

Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6af1d0d4aeeb810cfaecad95c9014beb66bfc63d

@k8s-ci-robot k8s-ci-robot merged commit 014d4ec into kubernetes-sigs:main Jul 24, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Jul 24, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michal.
Could you open an issue to remember reverting this PR?

@tenzen-y
Copy link
Member

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #2687

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor Author

mimowo commented Jul 24, 2024

Thanks Michal. Could you open an issue to remember reverting this PR?

I think this could be part of the existing issue #2414. If we cannot chery-pick the fix, then I think it makes more sense to update the documentation saying that "prior to version 0.9...". WDYT?

@tenzen-y
Copy link
Member

Thanks Michal. Could you open an issue to remember reverting this PR?

I think this could be part of the existing issue #2414. If we cannot chery-pick the fix, then I think it makes more sense to update the documentation saying that "prior to version 0.9...". WDYT?

That sounds reasonable! Thank you for the updates!

@ChristianZaccaria
Copy link
Contributor

Hello, coming back to this. Wondering if the fix should be cherry-picked or should I update the docs to say that this is needed prior to 0.9? Thanks!

@tenzen-y
Copy link
Member

tenzen-y commented Sep 3, 2024

Hello, coming back to this. Wondering if the fix should be cherry-picked or should I update the docs to say that this is needed prior to 0.9? Thanks!

I would vote to update docs since that is an enhancement feature, and the enhancement should not be cherry-picked.

ChristianZaccaria added a commit to ChristianZaccaria/kueue that referenced this pull request Sep 5, 2024
ChristianZaccaria added a commit to ChristianZaccaria/kueue that referenced this pull request Sep 5, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants