-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about the need to restart the kueue pod #2685
Add a note about the need to restart the kueue pod #2685
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @tenzen-y @ChristianZaccaria |
@mimowo: GitHub didn't allow me to assign the following users: ChristianZaccaria. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6af1d0d4aeeb810cfaecad95c9014beb66bfc63d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michal.
Could you open an issue to remember reverting this PR?
/cherry-pick website |
@tenzen-y: new pull request created: #2687 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I think this could be part of the existing issue #2414. If we cannot chery-pick the fix, then I think it makes more sense to update the documentation saying that "prior to version 0.9...". WDYT? |
That sounds reasonable! Thank you for the updates! |
Hello, coming back to this. Wondering if the fix should be cherry-picked or should I update the docs to say that this is needed prior to 0.9? Thanks! |
I would vote to update docs since that is an enhancement feature, and the enhancement should not be cherry-picked. |
…s-sigs#2685)" This reverts commit 014d4ec.
…s-sigs#2685)" This reverts commit 014d4ec.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
To avoid users confusion when the CRDs don't work.
This is needed until #2414 is fixed
Which issue(s) this PR fixes:
Related to #2414
Special notes for your reviewer:
We can remove the notes once the issue is fixed, if cherry-picked. If not cherry-picked, we can update the docs to say that this is needed prior to 0.9.
Does this PR introduce a user-facing change?