-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unclosed action error. #2683
Fix unclosed action error. #2683
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mbobrovskyi Could you share the result with the |
Yes, sure. ---
# Source: kueue/templates/manager/manager.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: kueue-controller-manager
namespace: 'kueue-system'
labels:
helm.sh/chart: kueue-0.1.0
app.kubernetes.io/name: kueue
app.kubernetes.io/instance: kueue
control-plane: controller-manager
app.kubernetes.io/version: "v0.8.0"
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: kueue
app.kubernetes.io/instance: kueue
control-plane: controller-manager
template:
metadata:
labels:
app.kubernetes.io/name: kueue
app.kubernetes.io/instance: kueue
control-plane: controller-manager
annotations:
charts.kueue.x-k8s.io/config-checksum: 8d11b03bf6e627c5ad2a0c1691a59ddb427c389c8e0a1c6247cff31da2e86ecf
kubectl.kubernetes.io/default-container: manager
spec:
containers:
- args:
- --config=/controller_manager_config.yaml
- --zap-log-level=2
command:
- /manager
image: "us-central1-docker.pkg.dev/k8s-staging-images/kueue/kueue:v0.8.0"
imagePullPolicy: Always
livenessProbe:
httpGet:
path: /healthz
port: 8081
initialDelaySeconds: 15
periodSeconds: 15
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
name: manager
ports:
- containerPort: 8082
name: visibility
protocol: TCP
- containerPort: 9443
name: webhook-server
protocol: TCP
readinessProbe:
httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 5
periodSeconds: 5
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
resources:
limits:
cpu: 500m
memory: 512Mi
requests:
cpu: 500m
memory: 512Mi
securityContext:
allowPrivilegeEscalation: false
volumeMounts:
- mountPath: /tmp/k8s-webhook-server/serving-certs
name: cert
readOnly: true
- mountPath: /controller_manager_config.yaml
name: manager-config
subPath: controller_manager_config.yaml
- args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --v=10
image: "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0"
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy
ports:
- containerPort: 8443
name: https
protocol: TCP
resources: {}
securityContext:
runAsNonRoot: true
serviceAccountName: kueue-controller-manager
terminationGracePeriodSeconds: 10
volumes:
- name: cert
secret:
defaultMode: 420
secretName: kueue-webhook-server-cert
- configMap:
name: kueue-manager-config
name: manager-config |
/lgtm |
LGTM label has been added. Git tree hash: bc38fd07039691efbf370aa7f19208a673f0be03
|
/release-note-edit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.8 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Oh, what a timing :) That's completely same timing :) |
@tenzen-y: new pull request created: #2688 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix "unclosed action" error.
Which issue(s) this PR fixes:
Fixes #2682
Special notes for your reviewer:
This issue reproduced with helm v3.5.2.
Does this PR introduce a user-facing change?