Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detailed preemption reason bug #2629

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix detailed preemption reason bug #2629

merged 1 commit into from
Jul 17, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Jul 16, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

If allowBorrowingBelowPriority is nil, then the reason should stay as InCohortReclamationReason

Which issue(s) this PR fixes:

Fixes #2404

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1dcfd4a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6697a6693183be0008e4078d

@vladikkuzn
Copy link
Contributor Author

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 16, 2024
@vladikkuzn vladikkuzn marked this pull request as ready for review July 16, 2024 19:48
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 16, 2024
@vladikkuzn
Copy link
Contributor Author

/cc @alculquicondor

alculquicondor
alculquicondor reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update TestPreemption so that we check also for the reason and not just the set of preempted workloads?

Otherwise we might be missing other bugs.

@vladikkuzn
Copy link
Contributor Author

Could you update TestPreemption so that we check also for the reason and not just the set of preempted workloads?

Good point, I only updated TestFairPreemptions in my last PR, will do

@vladikkuzn vladikkuzn force-pushed the fix-detailed-preemption-reason branch from b805aa9 to b0110e5 Compare July 17, 2024 09:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2024
@vladikkuzn
Fix detailed preemption reason bug
1dcfd4a 
* If allowBorrowingBelowPriority is nil, then the reason should stay as InCohortReclamationReason
* Add reason assertions to TestPreemption
@vladikkuzn vladikkuzn force-pushed the fix-detailed-preemption-reason branch from b0110e5 to 1dcfd4a Compare July 17, 2024 11:09
alculquicondor
alculquicondor reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 672ca9ab430b82278d9645290145bf1ddc681598

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

Because the previous PR was not part of a release yet.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d7d698 into kubernetes-sigs:main Jul 17, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 17, 2024
@vladikkuzn vladikkuzn deleted the fix-detailed-preemption-reason branch July 17, 2024 19:52
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@vladikkuzn @kannon92
Fix detailed preemption reason bug (kubernetes-sigs#2629)
4b01ba2 
* If allowBorrowingBelowPriority is nil, then the reason should stay as InCohortReclamationReason
* Add reason assertions to TestPreemption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

@vladikkuzn vladikkuzn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Distinguish between Preemption due to reclamation and fair sharing
3 participants
@vladikkuzn @k8s-ci-robot @alculquicondor