fix: wrong use of apivalication.ValidateImmutableField

[xuxianzhang]

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

wrong use of apivalication.ValidateImmutableField, order of parameters is (newObj,oldObj,fieldPath) not is (oldObj,newObj,fieldPath)
add two test cases:

1. immutable queue name not suspend
2. queue name can changes when it is suspend

Does this PR introduce a user-facing change?

Fix the validation messages, to report the new value rather than old, for the following immutable labels: `kueue.x-k8s.io/queue-name`, `kueue.x-k8s.io/prebuilt-workload-name`, and `kueue.x-k8s.io/priority-class`.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: xuxianzhang / name: 徐宪章 (8f915ec, aedfe1f)

[k8s-ci-robot]

Welcome @xuxianzhang!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @xuxianzhang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	aedfe1f
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/668bcf24fa6dd500080ac1dc

[xuxianzhang]

/assign @mimowo @tenzen-y

[mbobrovskyi]

/ok-to-test

[mimowo]

Thanks!. Also update it here

[xuxianzhang]

Thanks!. Also update it here

All done.
It was an oversight on my part not to do a thorough test

[mimowo]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c8621608cd8c7b64da6c9c69ffd8f5d4b905ca13

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, xuxianzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

I think this actually have a user-facing impact, though minimal:

/release-note-edit

Fix the validation messages, to report the new value rather than old, for the following immutable 
labels: `kueue.x-k8s.io/queue-name`, `kueue.x-k8s.io/prebuilt-workload-name`, and `kueue.x-k8s.io/priority-class`.

[mimowo]

/cherry-pick release-0.7

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #2548

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.