-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kueuectl] Add list resourceflavor command. #2525
[kueuectl] Add list resourceflavor command. #2525
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
738a3b4
to
ed16edb
Compare
/retest |
/assign @trasc |
ed16edb
to
67d54e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: efe7ba6a457e3cea4f31f4ac208bc6eb8b405771
|
/cc @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
||
Output: | ||
|
||
* Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm... maybe it's worth adding the node labels, but it can be a separate PR to update the CRD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up #2557
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for comment |
/hold cancel |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
kueuectl create resourceflavor
command.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?