-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preemption when requesting 0 of a resource at nominal quota #2520
Fix preemption when requesting 0 of a resource at nominal quota #2520
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @gabesaba |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/cherry-pick release-0.7 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change-Id: I586a26b7c753da26d4460e5d2e231cecff3e58d8
d21aee6
to
30e7799
Compare
/test pull-kueue-test-e2e-main-1-30 |
/lgtm |
LGTM label has been added. Git tree hash: b917b52d377a76bd51341a0d7fcdd55e73c07a63
|
@alculquicondor: #2520 failed to apply on top of branch "release-0.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -86,8 +87,8 @@ func TestPreemption(t *testing.T) { | |||
utiltesting.MakeClusterQueue("c1"). | |||
Cohort("cohort"). | |||
ResourceGroup(*utiltesting.MakeFlavorQuotas("default"). | |||
Resource(corev1.ResourceCPU, "6", "12"). | |||
Resource(corev1.ResourceMemory, "3Gi", "6Gi"). | |||
Resource(corev1.ResourceCPU, "6", "6"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference: The limit of 12 was not accurate, as there are only 6 units available for borrowing.
…rnetes-sigs#2520) Change-Id: I586a26b7c753da26d4460e5d2e231cecff3e58d8
What type of PR is this?
/kind bug
What this PR does / why we need it:
The existing check that prevents borrowing when preempting didn't take in consideration that a workload could explicitly request 0 for a resource in a ClusterQueue that is at or over nominal quota.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?