Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PodSetInfo] Skip duplicate Tolerations during merge. #2498

Merged

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jun 28, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Skip duplicate Tolerations during PodSetInfo merge.

Which issue(s) this PR fixes:

Fixes #2427

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Skip duplicate Tolerations when an admission check introduces a toleration that the job also set.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a07e06a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/667ecc4fc28bdc00089892e5
😎 Deploy Preview https://deploy-preview-2498--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2024
@trasc
Copy link
Contributor Author

trasc commented Jun 28, 2024

/cc @alculquicondor

@alculquicondor
Copy link
Contributor

What is the user-facing behavior? The release note talks in terms of code.

Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6851bd34220aa895f23f528d4db28d10c21bb478

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

Skip duplicate Tolerations when an admission check introduces a toleration that the job also set.

@alculquicondor
Copy link
Contributor

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit aeb7d5f into kubernetes-sigs:main Jun 28, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 28, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: new pull request created: #2499

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@trasc trasc deleted the drop-duplicates-on-pod-info-merge branch June 28, 2024 16:59
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller fails attempting to add duplicate tolerations
4 participants