Fix lint issue reported by fatcontext

[alexandear]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR refactors queueReconcileForWorkloadsOfClusterQueue to avoid using nested contexts, as it has become unwieldy. This issue was identified by the fatcontext linter.

Special notes for your reviewer:

We don't need nested context in our case ctx = ctrl.LoggerInto(ctx, log).

Also, nested contexts may cause performance issues. See more about fat contexts here https://gabnotes.org/fat-contexts/

Does this PR introduce a user-facing change?

Fix performance issue in logging when processing LocalQueues.

[k8s-ci-robot]

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	97a873c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/667d33f953902b0008dff016
😎 Deploy Preview	https://deploy-preview-2485--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alculquicondor]

oh this looks very problematic

/lgtm
/approve
/ok-to-test
/cherry-pick release-0.7

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, alexandear

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0a381d28a623cd0b79ffacdab1d1664b47b66ee3

[alculquicondor]

/remove-kind cleanup
/kind bug

[mbobrovskyi]

/retest

[alculquicondor]

/cherry-pick release-0.7

[k8s-infra-cherrypick-robot]

@alculquicondor: #2485 failed to apply on top of branch "release-0.7":

Applying: Fix lint issue reported by fatcontext
Using index info to reconstruct a base tree...
M	.golangci.yaml
M	pkg/controller/core/workload_controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/core/workload_controller.go
CONFLICT (content): Merge conflict in pkg/controller/core/workload_controller.go
Auto-merging .golangci.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix lint issue reported by fatcontext
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alculquicondor]

@alexandear could you prepare a cherry-pick?

[alexandear]

Cherry-picked in #2492