Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multikueue] Batch remote workload reconcile events. #2380

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[multikueue] Batch remote workload reconcile events. #2380

merged 2 commits into from
Jun 11, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Jun 7, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

[multikueue] Batch remote workload reconcile events.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Multikueue: Batch reconcile events for remote workloads.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 059106f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66674b96f8dfec000859744c

mimowo
mimowo reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm. I just doubt we benefit from parametrizing it for tests if the batch period is just 1s.

We could just use the constant as in other use-cases: https://github.com/search?q=repo%3Akubernetes-sigs%2Fkueue+constants.UpdatesBatchPeriod&type=code.

pkg/controller/admissionchecks/multikueue/controllers.go Outdated Show resolved Hide resolved
mimowo
mimowo reviewed Jun 10, 2024
View reviewed changes
pkg/controller/admissionchecks/multikueue/workload_test.go
@@ -1050,7 +1050,7 @@ func TestWlReconcile(t *testing.T) {
}

helper, _ := newMultiKueueStoreHelper(managerClient)
reconciler := newWlReconciler(managerClient, helper, cRec, defaultOrigin, defaultWorkerLostTimeout)
reconciler := newWlReconciler(managerClient, helper, cRec, defaultOrigin, defaultWorkerLostTimeout, time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be ok not to parametrize it. but if you do, then let's use 100ms to get (slightly) better runtimes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is not relevant in this test.

@mimowo
Copy link
Contributor

mimowo commented Jun 11, 2024

I'm still in doubt what is the benefit of making it parametrized, but it is non-blocking.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 331e310e9102462d919a1261b4fde3bbe2174357

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1ae95f3 into kubernetes-sigs:main Jun 11, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 11, 2024
@trasc trasc deleted the multikueue-batch-events branch June 11, 2024 08:45
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@trasc @Fiona-Waters
[multikueue] Batch remote workload reconcile events. (kubernetes-sigs…
9f8b29a 
…#2380)

* [multikueue] Batch remote workload reconcile events.

* Review remarks
@alculquicondor
Copy link
Contributor

/release-note-edit

Multikueue: Batch reconcile events for remote workloads.

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@trasc @kannon92
[multikueue] Batch remote workload reconcile events. (kubernetes-sigs…
8eebc89 
…#2380)

* [multikueue] Batch remote workload reconcile events.

* Review remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladikkuzn vladikkuzn vladikkuzn left review comments

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@trasc @mimowo @k8s-ci-robot @alculquicondor @vladikkuzn