Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configAPI: Implement waitForPodsReady validations #2214

Merged
merged 1 commit into from
May 17, 2024
Merged

configAPI: Implement waitForPodsReady validations #2214

merged 1 commit into from
May 17, 2024

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

I implemented the .waitForPodsReady validations.
Also, I consolidated the valid test cases for the waitForPodsReady into one case, and added fields to the defaulting tests.

Which issue(s) this PR fixes:

Part-of #2084

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added validations for the "waitForPodsReady.timeout" in the Configuration.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc May 17, 2024 07:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 915a126
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66470c049673660008487f6e
😎 Deploy Preview https://deploy-preview-2214--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tenzen-y tenzen-y mentioned this pull request May 17, 2024
Closed
4 tasks
mimowo
mimowo reviewed May 17, 2024
View reviewed changes
pkg/config/config_test.go
@@ -152,9 +152,12 @@ apiVersion: config.kueue.x-k8s.io/v1beta1
kind: Configuration
waitForPodsReady:
enable: true
timeout: 50s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit question: any reason for changes in this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified this test data because there are no test cases to verify if overrided parameters are propagated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm, I see this is what we do also for other fields

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. Maybe we forgot to add these fields here when we extend waitForPodsReadt feature :)

@mimowo
Copy link
Contributor

mimowo commented May 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb5fc69531ab65dedef1ce16b9f3821297a9b88b

@k8s-ci-robot k8s-ci-robot merged commit 0fac8ff into kubernetes-sigs:main May 17, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 17, 2024
@tenzen-y tenzen-y deleted the implement-waitforpodsready-validation branch May 17, 2024 09:58
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@tenzen-y @kannon92
configAPI: Implement waitForPodsReady validations (kubernetes-sigs#2214)
2493991 
Signed-off-by: Yuki Iwai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@tenzen-y @k8s-ci-robot @mimowo