Improve logging of workload status #2062
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
|
/assign @tenzen-y @alculquicondor |
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -660,9 +661,12 @@ func workloadStatus(w *kueue.Workload) string { | |||
| if apimeta.IsStatusConditionTrue(w.Status.Conditions, kueue.WorkloadFinished) { | |||
| return finished | |||
| } | |||
| if workload.HasQuotaReservation(w) { | |||
| if workload.IsAdmitted(w) { | |||
There was a problem hiding this comment.
do we really need this distinction? Can we just track quotaReserved?
There was a problem hiding this comment.
Yeah, I was thinking about it, and chose this approach because:
- just renaming to
quotaReservedwould mean we still have misleading logs, but the other way round - having more granular status might be helpful, for example here we only need to enter for admitted
I guess if we have too many occurences of (quotaReserved || admitted) then we could wrap them with quotaReservedOrAdmitted helper function.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c934797e4eef381f19a2cdd7e80503da19e82b27
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alculquicondor @tenzen-y should we cherry-pick this? On one hand this is just logs, but OTOH it could be helpful to investigate workloads using ProvReq on 0.6.3. WDYT? |
Considering this conflict (#2061 (comment)), I'd like to vote to cherry pick this PR. |
|
sgtm |
|
/cherry-pick release-0.6 |
|
@mimowo: new pull request created: #2080 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, the log messages suggest that the workload is admitted, only if it has quota reserved.
This is confusing when debugging issues related to admission checks.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?