Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of pod reconcilers in default chart values #2046

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix number of pod reconcilers in default chart values #2046

merged 1 commit into from
Apr 24, 2024

Conversation

alculquicondor
Copy link
Contributor

@alculquicondor alculquicondor commented Apr 23, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

We forgot to update this in #1835

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Helm: Fix chart values configuration for the number of reconcilers for the Pod integration.

@alculquicondor
Fix number of pod reconcilers in default chart values
2059146 
Change-Id: Ibeaf93a0f897524860e7046586249528161fd65a
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 2059146
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6627e2fc68a87900085d94c8
😎 Deploy Preview https://deploy-preview-2046--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tenzen-y
tenzen-y reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 804f5c800aadb69a58c59cbc1e75c251ef6ed362

@tenzen-y
Copy link
Member

/cherry-pick release-0.6

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 36b340e into kubernetes-sigs:main Apr 24, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Apr 24, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #2050

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 24, 2024
Merged
@alculquicondor
Copy link
Contributor Author

/release-note-edit

Helm: Fix chart values configuration for the number of reconcilers for the Pod integration.

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@alculquicondor @kannon92
Fix number of pod reconcilers in default chart values (kubernetes-sig…
13af4a8 
…s#2046)

Change-Id: Ibeaf93a0f897524860e7046586249528161fd65a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@alculquicondor @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot