Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cache] Don't assign finished workloads to newly add CQs. #1689

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[cache] Don't assign finished workloads to newly add CQs. #1689

merged 1 commit into from
Feb 7, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Feb 6, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Skips assigning Finished workloads to the newly added cluster queues in cache.

Which issue(s) this PR fixes:

Fixes #1654

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Avoid finished Workloads from blocking quota after a Kueue restart

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit edbe812
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c3959f8421e80008fccd91

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 6, 2024

/test all

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@trasc trasc marked this pull request as ready for review February 6, 2024 12:15
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 6, 2024

/cc @alculquicondor

@alculquicondor
Copy link
Contributor

Add a unit or integration test, please

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 7, 2024

Add a unit or integration test, please

done

alculquicondor
alculquicondor reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0f421ce9377ea9bce800d7954f676f7b16c1cab

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@alculquicondor
Copy link
Contributor

/hold
can you squash?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@trasc trasc force-pushed the cache-cq-no-finished-wl branch from 5ba0a03 to edbe812 Compare February 7, 2024 14:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 7, 2024

@alculquicondor done
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@alculquicondor
Copy link
Contributor

/lgtm
/cherry-pick release-0.5

@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1fa9364b51e5eb33eafc7408cf776841048b99bd

@k8s-ci-robot k8s-ci-robot merged commit f6d6ade into kubernetes-sigs:main Feb 7, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Feb 7, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: new pull request created: #1699

In response to this:

/lgtm
/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 7, 2024
Merged
@trasc trasc deleted the cache-cq-no-finished-wl branch February 7, 2024 16:45
@trasc trasc restored the cache-cq-no-finished-wl branch February 8, 2024 06:33
@trasc trasc deleted the cache-cq-no-finished-wl branch February 8, 2024 06:33
@mimowo mimowo mentioned this pull request Feb 9, 2024
Merged
@alculquicondor
Copy link
Contributor

/release-note-edit

Avoid finished Workloads from blocking quota after a Kueue restart

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 9, 2024
@mimowo mimowo mentioned this pull request Jul 8, 2024
Merged
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@trasc @kannon92
[cache] Don't assign finished workloads to newly add CQs. (kubernetes…
fe21fd4 
…-sigs#1689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Restarting controller manager admits all workloads
4 participants
@trasc @k8s-ci-robot @alculquicondor @k8s-infra-cherrypick-robot