[multikueue] Add garbage collector. #1643

trasc · 2024-01-25T13:03:57Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add MultiKueue garbage collection.
A component that periodically, based on kueueManagerConfig.MultiKueue.GCTimeout , lists the remote objects created on the remote MultiKueueClusters , having the label kueue.x-k8s.io/multikueue-origin set to config.multiKueue,origin , and delete those who no longer have a local counterpart.

Which issue(s) this PR fixes:

Relates to #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

MultiKueue: Add garbage collection of deleted Workloads.

k8s-ci-robot · 2024-01-25T13:03:59Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2024-01-25T13:04:02Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`ebe1e32`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c1159dacc5850008f19fbc

apis/kueue/v1alpha1/multikueueconfig_types.go

pkg/controller/admissionchecks/multikueue/workload.go

trasc · 2024-01-25T16:44:32Z

/test all

trasc · 2024-01-26T12:11:12Z

/hold
for #1631

trasc · 2024-01-29T08:52:59Z

/unhold

apis/config/v1beta1/configuration_types.go

apis/kueue/v1alpha1/multikueue_types.go

pkg/controller/admissionchecks/multikueue/multikueuecluster.go

apis/kueue/v1alpha1/multikueue_types.go

k8s-ci-robot · 2024-02-02T12:04:06Z

LGTM label has been added.

Git tree hash: 254effaa8d7d6cc18541fa549154eb106d19e808

mimowo · 2024-02-02T12:56:57Z

BTW, I don't think this warrants a separate release note, because this is a non-released feature yet. I think one generic release note saying "Support for MultiKueue at Alpha level" (from one PR) would be enough for users, but this is a nit.

tenzen-y

I have not yet reviewed integration tests.

apis/config/v1beta1/configuration_types.go

apis/config/v1beta1/defaults.go

apis/config/v1beta1/configuration_types.go

apis/config/v1beta1/defaults_test.go

pkg/controller/admissionchecks/multikueue/multikueuecluster.go

pkg/controller/admissionchecks/multikueue/multikueuecluster_test.go

cmd/kueue/main.go

pkg/controller/admissionchecks/multikueue/multikueuecluster.go

alculquicondor · 2024-02-05T16:47:59Z

pkg/controller/admissionchecks/multikueue/multikueuecluster.go

+				}
+			}
+		}
+		wlLog.V(5).Info("MultiKueueGC deleting remote workload")


this can be inside an "else", as deleting the owner would cascade the deletion of the workload without an additional API call.

I prefer to keep it as is, I find it easier to follow.

pkg/controller/admissionchecks/multikueue/multikueuecluster.go

alculquicondor · 2024-02-05T16:51:21Z

/approve
/hold
for comments

k8s-ci-robot · 2024-02-05T16:51:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alculquicondor · 2024-02-05T18:13:32Z

/lgtm

k8s-ci-robot · 2024-02-05T18:13:38Z

LGTM label has been added.

Git tree hash: 6121d5ba125ce1f6e953d6aaf37b35fe10980ea2

alculquicondor · 2024-02-05T18:31:13Z

/hold cancel

tenzen-y · 2024-02-12T20:52:29Z

/kind api-change

alculquicondor · 2024-02-13T19:40:10Z

/release-note-edit

MultiKueue: Add garbage collection of deleted Workloads.

* [multikueue] Add garbage collector. * Fix after rebase * Review Remarks * Extend API description. * Make Origin a global config. * Review Remarks * Use GCInterval in config * Review remarks * Rename gc timeout default const * Review Remarks and UT scenario cleanup. * [config] Make multikueue Origin pointer * Review remarks

k8s-ci-robot requested a review from denkensk January 25, 2024 13:04

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024

k8s-ci-robot requested a review from mimowo January 25, 2024 13:04

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 25, 2024

mimowo reviewed Jan 25, 2024

View reviewed changes

apis/kueue/v1alpha1/multikueueconfig_types.go Outdated Show resolved Hide resolved

pkg/controller/admissionchecks/multikueue/workload.go Outdated Show resolved Hide resolved

trasc force-pushed the multikueue-gc branch from 085677c to 138cd50 Compare January 25, 2024 16:44

trasc force-pushed the multikueue-gc branch 3 times, most recently from 138cd50 to c42fd3f Compare January 26, 2024 12:10

trasc changed the title ~~multikueue] Add garbage collector.~~ [multikueue] Add garbage collector. Jan 26, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024

trasc marked this pull request as ready for review January 26, 2024 12:11

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024

k8s-ci-robot requested a review from mimowo January 26, 2024 12:11

trasc force-pushed the multikueue-gc branch from c42fd3f to 5441160 Compare January 29, 2024 08:52

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024

mimowo reviewed Jan 29, 2024

View reviewed changes

apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved

mimowo reviewed Jan 29, 2024

View reviewed changes

apis/kueue/v1alpha1/multikueue_types.go Outdated Show resolved Hide resolved

mimowo reviewed Jan 31, 2024

View reviewed changes

trasc force-pushed the multikueue-gc branch from 5441160 to 56de7ed Compare January 31, 2024 12:22

k8s-ci-robot assigned mimowo Feb 2, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024

Rename gc timeout default const

cf085cd

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024

k8s-ci-robot requested review from alculquicondor, mimowo and tenzen-y February 2, 2024 14:04

tenzen-y reviewed Feb 2, 2024

View reviewed changes

trasc added 2 commits February 5, 2024 09:21

Review Remarks and UT scenario cleanup.

f04f5a4

[config] Make multikueue Origin pointer

d531485

alculquicondor reviewed Feb 5, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024

Review remarks

ebe1e32

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024

k8s-ci-robot merged commit 2326377 into kubernetes-sigs:main Feb 5, 2024
14 checks passed

k8s-ci-robot added this to the v0.6 milestone Feb 5, 2024

trasc deleted the multikueue-gc branch February 6, 2024 04:51

k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[multikueue] Add garbage collector. #1643

[multikueue] Add garbage collector. #1643

trasc commented Jan 25, 2024 •

edited by k8s-ci-robot

Loading

k8s-ci-robot commented Jan 25, 2024

netlify bot commented Jan 25, 2024 •

edited

Loading

trasc commented Jan 25, 2024

trasc commented Jan 26, 2024

trasc commented Jan 29, 2024

k8s-ci-robot commented Feb 2, 2024

mimowo commented Feb 2, 2024

tenzen-y left a comment

alculquicondor Feb 5, 2024

trasc Feb 5, 2024

alculquicondor commented Feb 5, 2024

k8s-ci-robot commented Feb 5, 2024

alculquicondor commented Feb 5, 2024

k8s-ci-robot commented Feb 5, 2024

alculquicondor commented Feb 5, 2024

tenzen-y commented Feb 12, 2024

alculquicondor commented Feb 13, 2024

[multikueue] Add garbage collector. #1643

[multikueue] Add garbage collector. #1643

Conversation

trasc commented Jan 25, 2024 • edited by k8s-ci-robot Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Jan 25, 2024

netlify bot commented Jan 25, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

trasc commented Jan 25, 2024

trasc commented Jan 26, 2024

trasc commented Jan 29, 2024

k8s-ci-robot commented Feb 2, 2024

mimowo commented Feb 2, 2024

tenzen-y left a comment

Choose a reason for hiding this comment

alculquicondor Feb 5, 2024

Choose a reason for hiding this comment

trasc Feb 5, 2024

Choose a reason for hiding this comment

alculquicondor commented Feb 5, 2024

k8s-ci-robot commented Feb 5, 2024

alculquicondor commented Feb 5, 2024

k8s-ci-robot commented Feb 5, 2024

alculquicondor commented Feb 5, 2024

tenzen-y commented Feb 12, 2024

alculquicondor commented Feb 13, 2024

trasc commented Jan 25, 2024 •

edited by k8s-ci-robot

Loading

netlify bot commented Jan 25, 2024 •

edited

Loading