-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #1561: Fix the borrowing while preemption when no borrowingLimit #1564
Automated cherry pick of #1561: Fix the borrowing while preemption when no borrowingLimit #1564
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM.
BTW, we want to cherry-pick #1496 to release-0.5 to avoid conflicts in the future before we merge this PR into release-0.5.
WDYT? @alculquicondor @mimowo
I'm fine either way. |
I think code has deviated already, so no need to cherry-pick cleanups |
/lgtm |
LGTM label has been added. Git tree hash: c74af2d77764ef793c83794258de8e372eab4c44
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #1561 on release-0.5.
#1561: Fix the borrowing while preemption when no borrowingLimit
For details on the cherry pick process, see the cherry pick requests page.
Note: I had a conflict with 7aff061, but the other PR didn't contribute logic difference, so I resolved the conflict by using the new logic for the
workloadFits
function.