Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #1561: Fix the borrowing while preemption when no borrowingLimit #1564

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jan 10, 2024

Cherry pick of #1561 on release-0.5.
#1561: Fix the borrowing while preemption when no borrowingLimit
For details on the cherry pick process, see the cherry pick requests page.

Note: I had a conflict with 7aff061, but the other PR didn't contribute logic difference, so I resolved the conflict by using the new logic for the workloadFits function.

@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2024
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 9c54289
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/659e667e11bcff0008883a74
😎 Deploy Preview https://deploy-preview-1564--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Jan 10, 2024

/assign @alculquicondor

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM.

BTW, we want to cherry-pick #1496 to release-0.5 to avoid conflicts in the future before we merge this PR into release-0.5.

WDYT? @alculquicondor @mimowo

@mimowo
Copy link
Contributor Author

mimowo commented Jan 10, 2024

BTW, we want to cherry-pick #1496 to release-0.5 to avoid conflicts in the future before we merge this PR into release-0.5.

I'm fine either way.

@alculquicondor
Copy link
Contributor

I think code has deviated already, so no need to cherry-pick cleanups

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c74af2d77764ef793c83794258de8e372eab4c44

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2397e10 into kubernetes-sigs:release-0.5 Jan 10, 2024
15 checks passed
@mimowo mimowo deleted the automated-cherry-pick-of-#1561-upstream-release-0.5 branch February 10, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants