-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HA support for the visibility API #1554
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Hi @astefanutti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-kueue-test-integration-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alculquicondor @tenzen-y
LGTM label has been added. Git tree hash: c3e81253492630f353045af24a57e2d8843b2ba8
|
86283c0
to
d7fbfd1
Compare
/test pull-kueue-test-e2e-main-1-29 |
Could you add a commit with the basic E2E test for HA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for e2e.
LGTM label has been added. Git tree hash: e51bd3986332be0b338375e3968e60fc1d2a666b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
* Add HA support for the visibility API * Deploy Kueue in HA mode in e2e tests * Insure against event misses during leader election failover * Decorate reconcilers only when leader election is enabled * Skip requests in non-leading replicas on not found errors
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables multiple replicas of the Kueue deployment to serve the visibility extension API endpoint.
This is achieved by:
controller.Options{NeedLeaderElection: ptr.To(false)}
as extra option to these controllers;WithLeadingManager(mgr, r)
, which discards the reconciliation requests for non-leading replicas (still consuming the requests from the event queues), until one acquires the leader election lease if the leading replica has failed to renew it.The scheduling decisions process is untouched and left to the responsibility of the leading replica, based on the state of its local queue manager.
Which issue(s) this PR fixes:
Fixes #1510
Special notes for your reviewer:
Does this PR introduce a user-facing change?