Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HA support for the visibility API #1554

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Jan 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables multiple replicas of the Kueue deployment to serve the visibility extension API endpoint.

This is achieved by:

  1. Starting controllers that feed the queue manager unconditionally, with the addition of controller.Options{NeedLeaderElection: ptr.To(false)} as extra option to these controllers;
  2. Skipping any actual reconciliation for these controllers, with the addition of WithLeadingManager(mgr, r), which discards the reconciliation requests for non-leading replicas (still consuming the requests from the event queues), until one acquires the leader election lease if the leading replica has failed to renew it.

The scheduling decisions process is untouched and left to the responsibility of the leading replica, based on the state of its local queue manager.

Which issue(s) this PR fixes:

Fixes #1510

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Visibility API: Add HA support.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from denkensk and trasc January 8, 2024 15:13
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit b4ae8f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65a13105d166370008872524

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2024
@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2024
@astefanutti
Copy link
Member Author

/test pull-kueue-test-integration-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @alculquicondor @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3e81253492630f353045af24a57e2d8843b2ba8

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2024
@astefanutti astefanutti force-pushed the pr-06 branch 2 times, most recently from 86283c0 to d7fbfd1 Compare January 11, 2024 11:29
@astefanutti
Copy link
Member Author

/test pull-kueue-test-e2e-main-1-29

@alculquicondor
Copy link
Contributor

Could you add a commit with the basic E2E test for HA?

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for e2e.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e51bd3986332be0b338375e3968e60fc1d2a666b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1adca15 into kubernetes-sigs:main Jan 25, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 25, 2024
@astefanutti astefanutti deleted the pr-06 branch January 26, 2024 09:07
@alculquicondor
Copy link
Contributor

/release-note-edit

Visibility API: Add HA support.

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
* Add HA support for the visibility API

* Deploy Kueue in HA mode in e2e tests

* Insure against event misses during leader election failover

* Decorate reconcilers only when leader election is enabled

* Skip requests in non-leading replicas on not found errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High availability of the visibility extension API server
5 participants