Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend a running Job without requeueing #1252

Merged

Commits on Dec 1, 2023

  1. Suspendable jobs feature

    removes evicted condition status update, removes job_controller unit tests, adds pkg job unit tests
    
    updated workload_controller log
    
    added StrictFIFO queueing strategy in e2e test while creating a second job when the first one is suspended
    
    changed behaviour in reconciler to allow kueue suspend a job directly from the workload signal, updated integration and job test, still missing to update the field name
    
    changing implementation to use active and not suspending the job manually
    
    updated yaml file
    
    addressed comments, removed log lines, used step 6 to handle workload eviction, fixed Active field to be a pointer, fixed e2e tests to use on Consistently method, still missing to make one unit test case work
    
    updated unit tests and integration tests with new implementation to evict a workload based on spec.active field
    
    added crd charts yaml
    
    added workloadspec.go file
    
    updated e2e and unit tests, missing to rebase commits
    
    added zz generated file
    
    addressed comments, moved e2e test to happen inside integration tests
    
    nit comments addressed
    
    nit comments addressed
    
    final nit comments addressed and changed Eviction constant to be WorkloadEvictedByDeactivation
    
    deleted by accident a comment, reverted
    
    updated workload types comment
    vicentefb committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    8f3ef1b View commit details
    Browse the repository at this point in the history