Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiKueue] Promote MultiKueue API and feature gate to Beta #3095

Closed
3 tasks
Tracked by #3192
mimowo opened this issue Sep 19, 2024 · 7 comments
Closed
3 tasks
Tracked by #3192

[MultiKueue] Promote MultiKueue API and feature gate to Beta #3095

mimowo opened this issue Sep 19, 2024 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Sep 19, 2024

What would you like to be added:

Promote the MultiKueue API to Beta.

Why is this needed:

For the ease of use.

The feature was first introduced in 0.6, and since then a bunch of issues have been fixed.

Completion requirements:

Issues I would like to get addressed before graduating (except from other graduation criteria mentioned in KEP):

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Sep 19, 2024

/cc @mwielgus @tenzen-y @alculquicondor @trasc

I think we should resolve #3094 before the gradution, but discussion is welcome.

@trasc
Copy link
Contributor

trasc commented Sep 19, 2024

/assign

@mimowo mimowo changed the title [MultiKueue] Promote MultiKueue API and feature gate Beta [MultiKueue] Promote MultiKueue API and feature gate to Beta Sep 19, 2024
@tenzen-y
Copy link
Member

@mimowo @trasc Could we finalize #2458 before we graduate MK?
I am suspecting that the new functional requirements will be found by #2458.

@mimowo
Copy link
Contributor Author

mimowo commented Sep 20, 2024

Thanks for the comment, I was thinking about it, but I think we don't need to block on it, here is the couple of thoughts I have:

  • it is very unlikely we will be able to finalize #2458 before end of November, given the load of other workstreams. The KEP proved to be challenging, and we need a proper design for it, which I think includes decoupling Job handling and ACs.
  • supporting external Jobs may will likely require new APIs, but I believe we can grow it later step by step, nothing in the current API seems would be blocking the support
  • in the past we supported built-in Jobs in Kueue (initially just batch Job) as Beta API, and only later we added Job framwork and expanded and support external Jobs. I believe we can repeat the pattern here, while already in Beta.
  • we are already getting user feedback that the current API is useful for JobSet, but the setup still requires many steps

EDIT: also, the support for external Jobs isn't mentioned in the KEP, so I believe we can de-couple it.

@tenzen-y
Copy link
Member

I discussed this graduation with @mimowo offline.
During the discussion, we agreed that external Job support would take a long time since #2458 has not been finalized and is pending status.

Additionally, I guess that this graduation would be useful for collecting feedback from users, and we can reflect the feedback to the external Job support. Based on user feedback, we will prepare the second beta version to support additional features and external Jobs.

Anyway, I agree with this beta graduation, but for the GA graduation, I would like to wait for external Job support.

@mimowo
Copy link
Contributor Author

mimowo commented Oct 22, 2024

/close
The remaining work is tracked in separate issue #3094

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closing this issue.

In response to this:

/close
The remaining work is tracked in separate issue #3094

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants