Download binaries from dl.k8s.io instead of a bucket #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
upodroid
commented
Nov 21, 2023
upodroid
force-pushed
the
use-dl-k8s-io
branch
from
7d2b42e
to
2b531ac
Compare
upodroid
force-pushed
the
use-dl-k8s-io
branch
3 times, most recently
from
9196232
to
1fe5a65
Compare
upodroid
force-pushed
the
use-dl-k8s-io
branch
from
1fe5a65
to
9d7f354
Compare
upodroid
force-pushed
the
use-dl-k8s-io
branch
from
b7a3dd0
to
7dee8a6
Compare
|
/assign @michelle192837 @jbpratt This is ready to be merged. Jobs are passing |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbpratt, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Dec 19, 2023
rifelpet
reviewed
Jan 9, 2024
| TestPackageVersion string `desc:"The ginkgo tester uses a test package made during the kubernetes build. The tester downloads this test package from one of the release tars published to the Release bucket. Defaults to latest. visit https://kubernetes.io/releases/ to find release names. Example: v1.20.0-alpha.0"` | ||
| TestPackageBucket string `desc:"The bucket which release tars will be downloaded from to acquire the test package. Defaults to the main kubernetes project bucket."` |
There was a problem hiding this comment.
This is causing test failures: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-aws-selinux/1744533959024316416
can we finish migrating all jobs to use the new flag, or add this back as a deprecated flag?
EDIT: updated here: kubernetes/test-infra#31585
ameukam
added a commit
to ameukam/kops
that referenced
this pull request
Jan 18, 2024
`--test-package-bucket` is removed on kubernetes-sigs/kubetest2#251 Signed-off-by: Arnaud Meukam <[email protected]>
zetaab
pushed a commit
to zetaab/kops
that referenced
this pull request
Jan 22, 2024
`--test-package-bucket` is removed on kubernetes-sigs/kubetest2#251 Signed-off-by: Arnaud Meukam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ameukam @BenTheElder @dims
Fixes: #239
Part of: kubernetes/test-infra#18789 and kubernetes/k8s.io#2396
kops is another large project that fetches from the kubernetes-release/k8s-release-dev buckets but it has a custom implementation at https://github.com/kubernetes/kops/tree/master/tests/e2e/pkg/tester that I'll fix separately.
Lets merge this as soon as code freeze is over and bump the kubekins-e2e image. We should start seeing jobs failing and we can fix them
Improvements: