Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the parameters needed to build arm64 binaries #229

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

chendave
Copy link
Member

@chendave chendave commented Jun 8, 2023

pls see: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1666321790525247488/build-log.txt

The job ci-kubernetes-node-arm64-ubuntu-serial is failing because the binaries, such as "ginkgo" are copied from the wrong location and they were build for linux/amd64 instead.

/cc @ike-ma
/cc @dims
/cc @pacoxu

ref:
kubernetes/kubernetes#118567
kubernetes/test-infra#29727

@k8s-ci-robot k8s-ci-robot requested review from dims and pacoxu June 8, 2023 09:47
@k8s-ci-robot
Copy link
Contributor

@chendave: GitHub didn't allow me to request PR reviews from the following users: ike-ma.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

pls see: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1666321790525247488/build-log.txt

The job ci-kubernetes-node-arm64-ubuntu-serial is failing because the binaries, such as "ginkgo" are copied from the wrong location and they were build for linux/amd64 instead.

/cc @ike-ma
/cc @dims
/cc @pacoxu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @chendave!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @chendave. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2023

/cc @MushuEE

@@ -58,6 +58,8 @@ type Tester struct {
BoskosHeartbeatIntervalSeconds int `desc:"How often (in seconds) to send a heartbeat to Boskos to hold the acquired resource. 0 means no heartbeat."`
BoskosLocation string `desc:"If set, manually specifies the location of the boskos server. If unset and boskos is needed"`
ImageConfigFile string `desc:"Path to a file containing image configuration."`
UseDockerizedBuild string `desc:"Use dockerized build for test artifacts"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bool or string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's bool, good catch!

@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2023

Link to https://github.com/kubernetes/kubernetes/blob/9f7e43915766607b7ff281b91caf17cca7123576/test/e2e_node/builder/build.go#L32-L34 for reviewing.

@dims
Copy link
Member

dims commented Jun 8, 2023

/approve

@chendave
Copy link
Member Author

chendave commented Jun 9, 2023

/assign @spiffxp @MushuEE

for review and approval, thanks!

@MushuEE
Copy link
Contributor

MushuEE commented Jun 12, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, dims, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 54297a4 into kubernetes-sigs:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants