-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the parameters needed to build arm64 binaries #229
Conversation
@chendave: GitHub didn't allow me to request PR reviews from the following users: ike-ma. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @chendave! |
Hi @chendave. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/cc @MushuEE |
pkg/testers/node/node.go
Outdated
@@ -58,6 +58,8 @@ type Tester struct { | |||
BoskosHeartbeatIntervalSeconds int `desc:"How often (in seconds) to send a heartbeat to Boskos to hold the acquired resource. 0 means no heartbeat."` | |||
BoskosLocation string `desc:"If set, manually specifies the location of the boskos server. If unset and boskos is needed"` | |||
ImageConfigFile string `desc:"Path to a file containing image configuration."` | |||
UseDockerizedBuild string `desc:"Use dockerized build for test artifacts"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bool or string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's bool, good catch!
Signed-off-by: Dave Chen <[email protected]>
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, dims, MushuEE The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pls see: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1666321790525247488/build-log.txt
The job ci-kubernetes-node-arm64-ubuntu-serial is failing because the binaries, such as "ginkgo" are copied from the wrong location and they were build for linux/amd64 instead.
/cc @ike-ma
/cc @dims
/cc @pacoxu
ref:
kubernetes/kubernetes#118567
kubernetes/test-infra#29727