-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add vim to kubespray docker image #9805
Conversation
Signed-off-by: Anant Vijay <[email protected]>
|
Welcome @XDRAGON2002! |
Hi @XDRAGON2002. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @XDRAGON2002 |
Hum.. I don't have the precise overhead that this will add (in terme of size) but adding both VI and NANO seems a bit excessive. |
I think going with just vim should be sufficient keeping in mind the required use case. |
Signed-off-by: Anant Vijay <[email protected]>
Made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XDRAGON2002 Thank you, fine for me to add back vim to the image 🙇
@floryut Thanks! This was my first contribution to the k8s org as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @XDRAGON2002 and Thank you.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mzaian, XDRAGON2002 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* install nano/vi/vim Signed-off-by: Anant Vijay <[email protected]> * update Dockerfile Signed-off-by: Anant Vijay <[email protected]> --------- Signed-off-by: Anant Vijay <[email protected]>
* install nano/vi/vim Signed-off-by: Anant Vijay <[email protected]> * update Dockerfile Signed-off-by: Anant Vijay <[email protected]> --------- Signed-off-by: Anant Vijay <[email protected]>
* install nano/vi/vim Signed-off-by: Anant Vijay <[email protected]> * update Dockerfile Signed-off-by: Anant Vijay <[email protected]> --------- Signed-off-by: Anant Vijay <[email protected]>
* install nano/vi/vim Signed-off-by: Anant Vijay <[email protected]> * update Dockerfile Signed-off-by: Anant Vijay <[email protected]> --------- Signed-off-by: Anant Vijay <[email protected]>
* install nano/vi/vim Signed-off-by: Anant Vijay <[email protected]> * update Dockerfile Signed-off-by: Anant Vijay <[email protected]> --------- Signed-off-by: Anant Vijay <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for nano/vi/vim to the Dockerfile so that they can be accessed inside the respective container.
Which issue(s) this PR fixes:
Fixes #9710
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?: