-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add featureDetectOverride configration of calico #9249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lou-lan Thank you for the added feature
/ok-to-test
/ok-to-test it's an important config to solve the issue. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, lou-lan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Discussion: Recommand to the set the defaul value calico_feature_detect_override: "ChecksumOffloadBroken=true" to Fixes #8992. The solution is used by:
So, I suggest setting the default value to the ChecksumOffloadBroken=true, to disable the VLAN offload by default, so the calico can be worked in most cases. And if the user wants to use VLAN offload, he can change the configuration. |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8992
Special notes for your reviewer:
Does this PR introduce a user-facing change?: