-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Ambassador ingress code #8086
Conversation
Skipping CI for Draft Pull Request. |
@aztechian let's wait a few days/week before merging this one, but I'm preparing it as I don't have a lot of hope ;) |
Agreed. Sounds good. |
Nop it won't, the |
eb969fc
to
bed9e50
Compare
/cc @aztechian @oomichi @EppO |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aztechian, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sounds reasonable to remove the Ambassador ingress for me. /lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Ambassador is no longer maintained and is not working anymore.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
See discussion #6135 (comment)
And issue in ambassador repo here datawire/ambassador-operator#73
Does this PR introduce a user-facing change?: