Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump requirements.txt versions / remove ansible_python_interpreter hack #5847

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Bump requirements.txt versions / remove ansible_python_interpreter hack #5847

merged 2 commits into from
Apr 7, 2020

Conversation

champtar
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Ansible 2.8+ gives us ansible_python_interpreter auto-detection
Many distributions are shipping latest and greatest version of Ansible, so we should validate that it works
While at it just bump everything and see if the CI pass
I'm not bumping the minimum required version for now

Which issue(s) this PR fixes:
NONE, but bumping Ansible version help for CentOS 8 / Ubuntu 20.04

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update versions in requirements.txt

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @champtar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten March 27, 2020 15:45
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Mar 27, 2020

We should also update README.md

@champtar champtar force-pushed the requirements branch 2 times, most recently from d007e9d to fd6db39 Compare March 27, 2020 21:24
@champtar
Copy link
Contributor Author

tf-ovh_ubuntu18-calico failed again with: Failed to connect to the host via ssh: [email protected]: Permission denied (publickey).

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 30, 2020

From what I have tested, CentOS 8 and Ubuntu 20.04 are detected correctly from Ansible 2.8.

Looks good to me, but let's see what other think.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@champtar
Copy link
Contributor Author

just rebased on master to get the K8S 1.17 commit

This was referenced Mar 31, 2020
Merged
Closed
@Miouge1 Miouge1 added this to the 2.13 milestone Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2020
@champtar
Copy link
Contributor Author

champtar commented Apr 1, 2020

Rebased

@champtar
Copy link
Contributor Author

champtar commented Apr 1, 2020

/test packet_centos7-kube-ovn

@champtar
Copy link
Contributor Author

champtar commented Apr 1, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@champtar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@champtar
requirements.txt: Bump versions
a839bb3 
Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <[email protected]>
@champtar
tests: do not force ansible_python_interpreter
9b52f21 
we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <[email protected]>
@champtar
Copy link
Contributor Author

champtar commented Apr 3, 2020

As discussed with @Miouge1 on slack, the idea is to merge this start of next week, so if you have any comments please make them now

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 7, 2020

Finally we're able to get to a recent Ansible version.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2f19d96 into kubernetes-sigs:master Apr 7, 2020
@champtar champtar deleted the requirements branch April 7, 2020 14:28
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
@champtar @LuckySB
Bump requirements.txt versions / remove ansible_python_interpreter ha…
a754d14 
…ck (kubernetes-sigs#5847)

* requirements.txt: Bump versions

Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <[email protected]>

* tests: do not force ansible_python_interpreter

we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <[email protected]>
erulabs added a commit to kubesail/kubespray that referenced this pull request Apr 9, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
8b7dc1e 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits)
  Remove hard-coded dependance to docker.service in kubelet.service file (kubernetes-sigs#5917)
  Update Calico to v3.13.2, Multus to v3.4.1. Add ConfigMap get permission to allow calico-node access to kubeadm config. (kubernetes-sigs#5912)
  Fix idempotence issue in bootstrap-os (kubernetes-sigs#5916)
  Terraform/OpenStack: Fix idempotency bug in module.network.openstack_networking_router_interface_v2.k8s[0] (kubernetes-sigs#5914)
  Add kubernetes 1.18.1 hashes (kubernetes-sigs#5915)
  Proxy fixes (kubernetes-sigs#5869)
  Remove 1.16.x flag for tf-ovh_coreos-calico (now 1.17 ready) (kubernetes-sigs#5853)
  Update docker RHEL/CentOS versions to the latest patch versions available. (kubernetes-sigs#5872)
  Fix conntrack for opensuse and docker support (kubernetes-sigs#5880)
  Add crictl 1.18.0 hashes for k8s 1.18 (kubernetes-sigs#5877)
  fix readonly flexvolume in fcos and coreos (kubernetes-sigs#5885)
  Fix scaling (kubernetes-sigs#5889)
  Fix chicken and egg problem with proxy_env not defined on the first … (kubernetes-sigs#5896)
  make explicit that doc is at kubespray.io (kubernetes-sigs#5878)
  add local-path-provosioner helper image def (kubernetes-sigs#5817)
  remove unused kubelet options (kubernetes-sigs#5903)
  Change docker.io repo to variable and upgrade alb image (kubernetes-sigs#5898)
  Replace latest tags for csi drivers (kubernetes-sigs#5899)
  CentOS 8 CI (kubernetes-sigs#5842)
  Bump requirements.txt versions / remove ansible_python_interpreter hack (kubernetes-sigs#5847)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
3 participants
@champtar @k8s-ci-robot @Miouge1