Add molecule test for bootstrap-os #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Miouge1
force-pushed
the
molecule-bootstrap
branch
8 times, most recently
from
bdd2863 to
b662c5f
Compare
Miouge1
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Miouge1
force-pushed
the
molecule-bootstrap
branch
from
b662c5f to
60e1c30
Compare
Miouge1
force-pushed
the
molecule-bootstrap
branch
from
60e1c30 to
463be96
Compare
k8s-ci-robot
added
size/M
|
@aharrisson and @MarkusTeufelberger you worked a lot with Molecule in other PRs, maybe you have some input on this? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds molecule test with Vagrant driver and libvirt plugin.
Special notes for your reviewer:
Currently only testing Ubuntu 18.04, but more platforms could be added later on, we need to start somewhere.
The libvirt plugin makes this portable (KVM on Linux and VirtualBox on Mac).
The quay.io/miouge/kubespray-vagrant image could be moved to the kubespray org.
Adding
is_fedora_coreos: falseotherwise that variable is undefined.Inspired and related to #5487, #5129 and master...MarkusTeufelberger:molecule_bootstrap_tests