-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that ansible 2.7.10 is used rather than 2.8 (latest) #4822
Ensure that ansible 2.7.10 is used rather than 2.8 (latest) #4822
Conversation
Welcome @ccravens! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ccravens curious, is any issue related to ansible 2.8 not being supported ? |
requirements.txt
Outdated
@@ -1,4 +1,4 @@ | |||
ansible>=2.7.8 | |||
ansible>=2.7.8,<2.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather stick to a specific version (2.7.10) so it works similarly for people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this anyways just mostly used in CI? I hope people are not installing Ansible for the first time when starting to use Kubespray...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. But I'd rather stick to a specific version in a release, so we make sure it "works" in backward. If we hard pin it to 2.7.10 we are sure people actually USE that version (if they at least do pip install before they do cluster stuff)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes-sigs/kubespray#requirements lists "Ansible version ... (or newer) [...]" - this then should also probably be changed to something like "Ansible version 2.7.10, all older and newer versions are supported on a best effort basis but not guaranteed to work"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Let's update that! @ccravens can you do so ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, didn't see this mention, I got the 2.7.10 enforcement pushed up now for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase from master to make the CI work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkusTeufelberger for our case we are attempting to install k8s using vanilla AWS EC2 AMI that do not have ansible installed, so the ansible dependency is being installed through the requirements.txt file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@woopstar I just noticed when rebasing master that it seems they are enforcing ansible to 2.7.8 now in master... Should we leave as 2.7.8? Or updated to 2.7.10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to 2.7.8 so it follows master branch or update to 2.7.10 and also do another PR to update to 2.7.10 in master ;)
ping @ccravens |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ccravens The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ccravens: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was fixed in #4783 |
@holmsten: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
It seems that kubespray does not yet support Ansible 2.8 which was recently released. But because the requirements file had anything above 2.7, it seems that it's pulling in 2.8.
Which issue(s) this PR fixes:
Fixes #
NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
NONE