Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ingress default-backend svc #4745

Conversation

okamototk
Copy link
Contributor

default-backend svc in ingress-nginx plugin doesn't have any endpoints. So it should be removed.

This fix #4742.

* default-backend svc doesn't have any endpoints.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: okamototk
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattymo

If they are not already assigned, you can assign the PR to them by writing /assign @mattymo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Miouge1 and mirwan May 11, 2019 15:03
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2019
@okamototk okamototk mentioned this pull request May 11, 2019
@okamototk
Copy link
Contributor Author

This is duplicated to #4746.

@okamototk okamototk closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while add Windows Node
2 participants