Add update server field in kube-proxy kubeconfig #4027
Conversation
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
|
ci check this |
|
recover #3958 |
|
@riverzhang Can we share some details on when this is required for nginx-proxy? I'm not seeing that problem. |
|
if you deploy ha cluster by kubeadm. Need to prepare LB when kubeadm join and kubeadm init nginx-proxy requires kubelet to start it. so it isn‘t possible to provide lb to kubeadm before. |
|
@riverzhang which test is failing without this? I'm not seeing issues. Is the nginx LB enabled by default for most jobs? If this issue only affects the local nginx LB, we should make sure this only runs when that is enabled. |
riverzhang
force-pushed
the
kube-proxy
branch
from
8842f55 to
117855b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: riverzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
riverzhang
force-pushed
the
kube-proxy
branch
from
117855b to
689cc13
Compare
| @@ -1,7 +1,7 @@ | |||
| # Instance settings | |||
| cloud_image_family: centos-7 | |||
| cloud_region: us-central1-c | |||
| cloud_machine_type: "n1-standard-1" | |||
| cloud_machine_type: "n1-standard-2" | |||
There was a problem hiding this comment.
You should rebase to have this fixed
riverzhang
force-pushed
the
kube-proxy
branch
from
689cc13 to
b8d2b34
Compare
I know this is a bit hack. If you use cloud LB, you can use kubeadm's controlPlaneEndpoint to configure kube-proxy's server field. But for nginx-proxy, it didn't start when kubeadm init.
riverzhang
force-pushed
the
kube-proxy
branch
from
b8d2b34 to
3ed5f89
Compare
|
Ah. This one bite me today. Any chance on getting this merged in quickly? |
@riverzhang I never got a response here. |
|
@chadswen The data traffic does not point to the address of the nginx-proxy, but point to the address of one of the masters. |
I know this is a bit hack.
If you use cloud LB, you can use kubeadm's controlPlaneEndpoint to configure kube-proxy's server field.
But for nginx-proxy, it didn't start when kubeadm join.