Fix AWS Node Labels Error #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the `kubespray-aws-inventory.py` script always set a node_labels key to ansible_host. When AWS instance did not set property labels, it would be an empty string. The TASK `Write kubelet config file (kubeadm or non-kubeadm)` will failed with a msg: `AnsibleUndefinedVariable: 'unicode object' has no attribute 'items'`.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
/assign @bradbeam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
kubespray-aws-inventory.pyscript always set a node_labels keyto ansible_host.
When AWS instance did not set property labels, it would be an empty
string.
The TASK
Write kubelet config file (kubeadm or non-kubeadm)willfailed with a msg:
AnsibleUndefinedVariable: 'unicode object' has no attribute 'items'.This may fix #3739