-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/k8s win nodes hybrid cluster #2956
Changes from all commits
a085569
1185836
7a08ede
51e9efa
39165be
62e80bc
5cb8761
34bc7a2
2a279e3
3b773e6
4e40d9a
6c069bc
e62eb1d
89d4424
e6f8259
67e15c4
4092f96
4d7426e
0b939a4
5c617c5
915ea26
0d1bd1e
f32a14b
d961d40
d1af8bd
3fad479
a8a4265
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,3 +54,8 @@ spec: | |
- --default-params={"linear":{"nodesPerReplica":{{ dnsmasq_nodes_per_replica }},"preventSinglePointFailure":true}} | ||
- --logtostderr=true | ||
- --v={{ kube_log_level }} | ||
{% if kube_patch_win_nodes %} | ||
# When having win nodes in cluster without this patch, this pod cloud try to be created in windows | ||
nodeSelector: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. isn't safe to always add this selector ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the past I have sent merge request with the selector added without if and someone else asked to add something like this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where did you find this label: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's perfectly legit to add it, https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/#beta-kubernetes-io-os |
||
beta.kubernetes.io/os: linux | ||
{% endif %} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Package: docker-ce | ||
Pin: version {{ docker_version }}.* | ||
Pin-Priority: 1001 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ | |
--ignore-preflight-errors=all | ||
--allow-experimental-upgrades | ||
--allow-release-candidate-upgrades | ||
--force | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks it got inserted but I forgot to remove, anyway it is safe to have this line. |
||
register: kubeadm_upgrade | ||
# Retry is because upload config sometimes fails | ||
retries: 3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Atoms
for when, only this needs to be changed?
Could be?
I haven't found examples to understand this syntax better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in playbook file, but in tasks files, i think for roles still not working such syntax (need to check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, haven't found other line I have changed to change now, probably could be reviewed in future PRs.